Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/is null #82

Merged
merged 28 commits into from
Jun 20, 2024
Merged

Feat/is null #82

merged 28 commits into from
Jun 20, 2024

Conversation

reifocS
Copy link
Contributor

@reifocS reifocS commented Jan 22, 2024 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

User can not search for null values
Issue Number: 52

What is the new behavior?

User can filter on null /not null values

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@codecov Codecov
Copy link

codecov bot commented Jan 22, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 74.07407% with 7 lines in your changes missing coverage. Please review.

Project coverage is 83.23%. Comparing base (912614d) to head (131c7ab).
Report is 2 commits behind head on master.

❗ Current head 131c7ab differs from pull request most recent head 8355580

Please upload reports for the commit 8355580 to get more accurate results.

Files Patch % Lines
.../sipios/springsearch/strategies/BooleanStrategy.kt 0.00% 0 Missing and 1 partial ⚠️
...com/sipios/springsearch/strategies/DateStrategy.kt 0.00% 0 Missing and 1 partial ⚠️
...m/sipios/springsearch/strategies/DoubleStrategy.kt 0.00% 0 Missing and 1 partial ⚠️
...sipios/springsearch/strategies/DurationStrategy.kt 0.00% 0 Missing and 1 partial ⚠️
.../sipios/springsearch/strategies/InstantStrategy.kt 0.00% 0 Missing and 1 partial ⚠️
.../com/sipios/springsearch/strategies/IntStrategy.kt 0.00% 0 Missing and 1 partial ⚠️
...ipios/springsearch/strategies/LocalTimeStrategy.kt 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master      #82      +/-   ##
============================================
+ Coverage     83.00%   83.23%   +0.22%     
- Complexity      123      132       +9     
============================================
  Files            22       22              
  Lines           306      328      +22     
  Branches         43       49       +6     
============================================
+ Hits            254      273      +19     
+ Misses           28       26       -2     
- Partials         24       29       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reifocS reifocS marked this pull request as ready for review January 22, 2024 10:21
@reifocS reifocS requested a review from lolo101 January 23, 2024 08:10
@reifocS reifocS changed the base branch from feat/gte-string to master January 23, 2024 17:51
@github-actions GitHub Actions
Copy link

⚡ Coverage report

Overall Project 85.54% -0.28% 🍏
Files changed 95.4% 🍏

File Coverage
EnumStrategy.kt 100% 🍏
LocalDateStrategy.kt 97.25% 🍏
QueryVisitorImpl.kt 96.93% 🍏
IntStrategy.kt 95.61% 🍏
SearchOperation.kt 94.63% 🍏
DateStrategy.kt 87.07% 🍏
LocalDateTimeStrategy.kt 86.24% 🍏
LocalTimeStrategy.kt 84.4% -1.83% ❌
ParsingStrategy.kt 82.83% 🍏
CollectionStrategy.kt 82.61% 🍏
UUIDStrategy.kt 66.67% 🍏
BooleanStrategy.kt 66.67% 🍏
InstantStrategy.kt 66.06% -1.83% ❌
FloatStrategy.kt 62.28% 🍏
DurationStrategy.kt 60.55% -1.83% ❌
DoubleStrategy.kt 60.53% -1.75% ❌

@phmz phmz merged commit 8e23f5f into master Jun 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lolo101 lolo101 lolo101 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@reifocS @lolo101 @phmz